I think we should move much less files. Otherwise it will be really bad in bigger packages.

I think we should move much less files. Otherwise it will be really bad in bigger packages.

Why not merge this pr with the proof that CJS works, then do the following which removes the CJS test

now on npmjs: unpacked size 34.3 kB
now on my branch: unpacked size 47.0 kB

If we have to move so many files then I would say it doesn't work and we shouldn't migrate

If we have to move so many files then I would say it doesn't work and we shouldn't migrate

AH you mean moving to mod, src ... ?

we can do without bu IMO it's will be better in term of maintainability

Most of the changes here are unnecessary. Simply changing module.export with export keyword should be all that's needed

Most of the changes here are unnecessary. Simply changing module.export with export keyword should be all that's needed

The idea of having main mod on ESM is to allowing JSR publish (REF discord discussion)

Unless that doesn't support npm packages, I don't understand the comment

Unless that doesn't support npm packages, I don't understand the comment

Could you rephrase your idea because I didn't get it

Can you change this PR so that it modifies the minimal amount of files and moves none ?

I can ofc

looks like this specific module has already been supporting esm since 2021 #17

looks like this specific module has already been supporting esm since 2021 #17

Yes, but no, the idea here is to put the esm first. As a reminder, the ultimate goal is to publish packages on JSR in order to move forward with the JS ecosystem.

bump @rom1504

New versions of node.js should be able to import between commonjs and ESM without needing library side changes, as long as one is used consistently over the other. So it may make sense to remove all the ESM exports

New versions of node.js should be able to import between commonjs and ESM without needing library side changes, as long as one is used consistently over the other. So it may make sense to remove all the ESM exports

I din't get your idea.

FYI:

• CJS imported in CJS => no problem
• CJS imported in ESM => may cause problems => solution for user const pkg = require("my-pkg"); const foo = pkg
• ESM imported in CJS => no problem
• ESM imported in ESM => no problem

So it'w why we should all use ESM for our packages